Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable installation via cargo #43

Open
charliermarsh opened this issue Aug 29, 2022 · 12 comments
Open

Enable installation via cargo #43

charliermarsh opened this issue Aug 29, 2022 · 12 comments
Labels
core Related to core functionality

Comments

@charliermarsh
Copy link
Member

We can't upload to crates.io because we're using an unreleased version of RustPython.

@charliermarsh
Copy link
Member Author

I've asked about publishing Ruff's RustPython fork here: RustPython/RustPython#4179

@youknowone
Copy link
Contributor

youknowone commented Oct 15, 2022

Regardless we are ready or not, I want to distribute rustpython-parser before ruff 0.1. Please poke me when you are ready for 0.1. I seriously don't want to block ruff's schedule by our fault.

@charliermarsh
Copy link
Member Author

@youknowone - Thank you, that's really helpful and appreciated.

There are a few PRs I'd need to merge to move off of my RustPython fork (which is largely ahead of main) -- I know you know about some of these, but I'll just enumerate them here for completeness:

@charliermarsh charliermarsh added core Related to core functionality and removed enhancement labels Dec 31, 2022
@charliermarsh
Copy link
Member Author

RustPython just cut a new release on crates.io. So the only blocker here is (1) confirming that we want to use the Crate, which might mean we're a little slower to pick up changes from Git; and (2) LibCST is still using my unpublished fork (which just removes pyo3 stuff).

@zanieb
Copy link
Member

zanieb commented Jun 3, 2023

Hey! I was looking at adding documentation for installation from crates.io then realized it wasn't supported :D

  1. Is it feasible to use RustPython from Git for other releases and only publish to crates.io if the published RustPython version has the sufficient changes? Is that worth the trouble?

  2. Is this resolved now?

@charliermarsh
Copy link
Member Author

I think there are three blockers here that we'd need to resolve, since, in order to publish to crates.io, we can't have any Git dependencies in the dependency tree:

  1. Publish our parser fork as their own crates (https://github.com/astral-sh/RustPython-Parser), e.g., ruff_rustpython_parser or similar.
  2. In RustPython (and our fork), remove the Git dependency on unicode_names2.
  3. Publish our LibCST fork as its own crate (https://github.com/charliermarsh/LibCST/tree/charlie/ruff).

@zanieb
Copy link
Member

zanieb commented Jun 3, 2023

Related RustPython/Parser#67

@youknowone
Copy link
Contributor

youknowone commented Jun 4, 2023

I'd like to grant publish permission of parser to anyone from Ruff who need it.
I didn't finish unicode_names2 patch to merge it yet. I need to port the implementation to its own phf.

@T-256
Copy link
Contributor

T-256 commented Oct 17, 2023

I think all mentioned blockers are gone, Are there any new?

@zanieb
Copy link
Member

zanieb commented Oct 17, 2023

Yes now that we've resolved the blockers we are considering publishing to crates.io but have not come to a decision yet.

@KGrewal1
Copy link

KGrewal1 commented Feb 18, 2024

Has there been any update on this (or would cargo install --git https://github.com/astral-sh/ruff ruff work: seems to install but I'm not sure if there's tests I can run to confirm: does seem to be working on code I have)

@charliermarsh
Copy link
Member Author

@KGrewal1 -- cargo install --git https://github.com/astral-sh/ruff ruff should work just fine! I tested it myself too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Related to core functionality
Projects
None yet
Development

No branches or pull requests

5 participants