Implement flake8-async

[dacevedo12]

https://github.com/cooperlees/flake8-async

It'd be good to implement (and hopefully extend) the concept of this project in enforcing best practices for asyncio usage.

[charliermarsh]

Looks pretty straightforward for anyone that's interested in learning to write rules for Ruff.

[inikolaev]

I want to give it a try - have a working prototype already and will push shortly.

[qdegraaf]

I want to give it a try - have a working prototype already and will push shortly.

Missed this. Had some chats about working on this the last few days in the Discord but did not mention it here. Just opened PR, but as a first time contributor I might not have come up with the most elegant solution. Happy to close for your solution if it's better, or merge the two or something else along those lines.

[inikolaev]

I want to give it a try - have a working prototype already and will push shortly.

Missed this. Had some chats about working on this the last few days in the Discord but did not mention it here. Just opened PR, but as a first time contributor I might not have come up with the most elegant solution. Happy to close for your solution if it's better, or merge the two or something else along those lines.

I'm a first time contributor as well, feel free to peek at what I've done so far: #4433

Still missing some docs for the violations

[inikolaev]

I should have checked open PRs as well, but assumed nobody was working on it yet :)

[qdegraaf]

Yeah I could have been more clear as well 😅 . Going to leave it to @charliermarsh to decide what's to happen for this one and be a bit more transparent on the next one.

[dacevedo12]

Please keep in mind the original one has a bug.

time.sleep -> triggers rule
from time import sleep -> doesnt

It also lacks validations for async defs that dont use await inside them.

Just pointing this out if the PRs port the code exactly as it is on that project to avoid the same mistakes

[dacevedo12]

Thanks for the contributions. I'd like to complement those myself but my skills in rust are currently lacking

[qdegraaf]

Please keep in mind the original one has a bug.

time.sleep -> triggers rule from time import sleep -> doesnt

It also lacks validations for async defs that dont use await inside them.

Just pointing this out if the PRs port the code exactly as it is on that project to avoid the same mistakes

Good catch., cheers! I'll mark mine as draft with some TODOs, but will hold off on implementing them in case #4433 covers that already, in which case I can close mine.

[charliermarsh]

I'm going to move forward with reviewing #4432 since it strikes me as a bit more complete (uses scoping logic to detect the async function context, includes documentation for the rules). I'm sorry @inikolaev, I know it's disappointing to put in work on a PR and not see it merged into the codebase, but we now have two similar PRs for the same scope of the work and so I have to choose between them somehow.

If you're interested in contributing, I'd love to help you find something else to work on (e.g., I'd love to finish the flake8-pyi rules from #848), but I totally understand if you'd rather not.

[inikolaev]

I'm going to move forward with reviewing #4432 since it strikes me as a bit more complete (uses scoping logic to detect the async function context, includes documentation for the rules). I'm sorry @inikolaev, I know it's disappointing to put in work on a PR and not see it merged into the codebase, but we now have two similar PRs for the same scope of the work and so I have to choose between them somehow.

If you're interested in contributing, I'd love to help you find something else to work on (e.g., I'd love to finish the flake8-pyi rules from #848), but I totally understand if you'd rather not.

No worries, I will look for something else to implement 👍