New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`assert_never` checks don't respect `typing-modules` #4000

Closed

charliermarsh opened this issue Apr 17, 2023 · 0 comments · Fixed by #4001

Assignees

Labels

bug

Member

charliermarsh commented Apr 17, 2023 •

edited

Loading

See: #3304 (comment).

charliermarsh changed the title Is it possible that the code ([I think here](https://github.com/charliermarsh/ruff/blob/280dffb5e161acb9deab97c9a2158055e4174d66/crates/ruff/src/rules/flake8_return/rules.rs#L201)) isn't accounting for the typing module reexport location? assert_never checks don't respect typing-modules

charliermarsh added the bug label

charliermarsh self-assigned this

charliermarsh mentioned this issue

Respect typing-modules when evaluating no-return functions #4001

Merged

charliermarsh closed this as completed in #4001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment