RET504 off-by-1 line / bogus error when returning an argument

[hynek]

Consider the following file t.py:

def str_to_bool(val):
    if isinstance(val, bool):
        return val
    val = val.strip().lower()
    if val in ("1", "true", "yes"):
        return True

    return False

Running pipx run ruff check --isolated --select RET504 t.py gives me:

t.py:3:16: RET504 Unnecessary variable assignment before `return` statement

So it points at the return val that hasn't assigned anything.

If I set val by hand instead of passing it in as an argument, there is no error.

---

$ pipx run ruff --version
ruff 0.0.261

no pyproject.toml

[charliermarsh]

👍 Definitely a bug.