Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(🐞) fix for E731 deletes type annotations #3973

Closed
KotlinIsland opened this issue Apr 14, 2023 · 2 comments · Fixed by #3983
Closed

(🐞) fix for E731 deletes type annotations #3973

KotlinIsland opened this issue Apr 14, 2023 · 2 comments · Fixed by #3983
Assignees
@dhruvmanila
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@KotlinIsland
Copy link
Contributor

input

sort_work_items: Callable[[int],int] = lambda it: it

expected

def sort_work_items(it: int) -> int:
    return it

actual

def sort_work_items(it):
    return it

playground
@KotlinIsland KotlinIsland changed the title (🐞) fix for E701 deletes type annotations (🐞) fix for E731 deletes type annotations Apr 14, 2023
@charliermarsh charliermarsh added bug Something isn't working good first issue Good for newcomers labels Apr 14, 2023
@dhruvmanila
Copy link
Member

I'll take this up today :)

@charliermarsh
Copy link
Member

Thanks @dhruvmanila!

@dhruvmanila dhruvmanila mentioned this issue Apr 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvmanila dhruvmanila

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve type annotations when fixing E731 dhruvmanila/ruff
3 participants
@charliermarsh @KotlinIsland @dhruvmanila