Ignore pragma when considering E501

[baggiponte]

I wrote this snippet of code and the <- ! line triggers E501.

def load_dynamodb(fileobj: IO | str | bytes | bytearray) -> dict[str, Any]:
    """Loads a dynamodb json fileobject."""
    if isinstance(fileobj, (str, bytes, bytearray)):
        return json.loads(fileobj, object_hook=_dynamo_hook)  # type: ignore [no-any-return] <- !
    return json.load(fileobj, object_hook=_dynamo_hook)  # type: ignore [no-any-return]

Since what triggers the warning is the pragma, I wanted to ask whether you believe that pragmas should not trigger E501 - something that Google has recently done with their pyink Python code formatter.

[charliermarsh]

Yeah that's an interesting question. I tend to agree, but let me leave this open for a bit to see if any other opinions come in.

[bryanforbes]

flake8-bugbear recently changed B950 to ignore noqa and type: ignore comments when determining whether to report the error or not, so there's some precedence for ignoring pragmas

[charliermarsh]

Oh that's great to know. Honestly that might be enough of a justification to just ship it :)

[baggiponte]

I would also add to the ignore list black's "# fmt: {on,off,skip}" 🙏🏻

[bryanforbes]

What I'd love to see is a way to configure which pragmas that ruff ignores. For my use, I would want it to ignore # noqa: code, # type: ignore[code], and # pyright: ignore[code], but others have pragmas they also want supported. Making it configurable makes everyone happy and also preserves the current behavior when left unconfigured.

[charliermarsh]

We made this change recently. It'll be out in the next release.