Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Windows, ruff doesn't support wildcards on the command line #3301

Closed
pfmoore opened this issue Mar 2, 2023 · 3 comments · Fixed by #3739
Closed

On Windows, ruff doesn't support wildcards on the command line #3301

pfmoore opened this issue Mar 2, 2023 · 3 comments · Fixed by #3739
Labels
bug Something isn't working cli Related to the command-line interface good first issue Good for newcomers

Comments

@pfmoore
Copy link

pfmoore commented Mar 2, 2023

The command ruff *.py gives the error "error: Failed to lint *.py: The filename, directory name, or volume label syntax is incorrect. (os error 123)". I would have expected it to check all .py files in the current directory.

@charliermarsh
Copy link
Member

Thanks! Will take a look. My guess is that we're relying on patterns being expanded by the shell (so e.g. on macOS, ruff *.py works but ruff "*.py" does not).

@charliermarsh charliermarsh added bug Something isn't working cli Related to the command-line interface labels Mar 2, 2023
@pfmoore
Copy link
Author

pfmoore commented Mar 2, 2023

Yeah, that's usually the issue. The Windows C runtime often does automatic glob expansion, but I guess Rust doesn't.

@charliermarsh charliermarsh added the good first issue Good for newcomers label Mar 18, 2023
@charliermarsh
Copy link
Member

We may be able to leverage this: https://gitlab.com/kornelski/wild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Related to the command-line interface good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants