PT006 fix adds unneeded parenthesis

[frenck]

PT006 seems to add additional parenthesis in case the string is already wrapped in a parenthesis to split it into multiple lines.

@pytest.mark.parametrize(
    (
        "create_backup_error, create_backup_calls, "
        "update_addon_error, update_addon_calls, "
        "error_message"
    ),
	[...]
)

Results in:

@pytest.mark.parametrize(
    (
        (
            "create_backup_error",
            "create_backup_calls",
            "update_addon_error",
            "update_addon_calls",
            "error_message",
        )
    ),
    [...]
)

Expected:

@pytest.mark.parametrize(
    (
        "create_backup_error",
        "create_backup_calls",
        "update_addon_error",
        "update_addon_calls",
        "error_message",
    ),
    [...]
)

[charliermarsh]

Thanks :)

[charliermarsh]

Ohh interesting, because the expression is itself parenthesized already. Hmm...

[dhruvmanila]

So, I was looking at the recent commit (abaf0a1) and thought of a similar approach in solving this problem.

The indexer will collect all the ranges for a pair of parenthesis (( to )). Then, while trying to generate a fix for the above case, we'll check how many ranges does the string expression range belongs to. If the value is 2, we won't add the parenthesis otherwise we will.

I'm not sure if you've any other solution in mind so just thought to share this.

[dhruvmanila]

Actually, I've a better solution in mind, will try to fix it by tonight.

[frenck]

Thanks, @dhruvmanila 👍

../Frenck

[charliermarsh]

Another all-star contribution from @dhruvmanila :)

[dhruvmanila]

Another all-star contribution from @dhruvmanila :)

Thanks for your kind words! Always happy to help wherever I can 😄