-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A006 and A002 both trigger for lambda's #14135
Comments
Nice catch! It looks like My only hesitation is that this would be a breaking change for a stable rule - so if people were running the checker with preview off and catching this shadowing on lambdas, they would no longer catch it if we matched Not sure the best protocol for handling this - @MichaReiser / @AlexWaygood ? |
Great question. When we expand the scope of a stable rule, we generally put the new behaviour in preview mode for a couple of months before promoting it to stable. When we reduce the scope of a rule, it's more of a judgement call. I can see the argument that this might be a breaking change for some people -- but it definitely feels like a bug to me to have two rules complain about the exact same error. So I'd be inclined to ship the behaviour change straight into stable for this one, so that users can benefit from the bugfix even if they haven't selected |
This example triggers two violations (with preview enabled), is this intentional?
The text was updated successfully, but these errors were encountered: