From fe9e35d81cfdb097d1c82a0a74bad8c4d4dc0b5b Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Thu, 25 Jan 2024 11:49:20 -0500 Subject: [PATCH] Format fixture --- .../test/fixtures/flake8_bugbear/B038.py | 25 +-- ...__flake8_bugbear__tests__B038_B038.py.snap | 160 +++++++++--------- 2 files changed, 88 insertions(+), 97 deletions(-) diff --git a/crates/ruff_linter/resources/test/fixtures/flake8_bugbear/B038.py b/crates/ruff_linter/resources/test/fixtures/flake8_bugbear/B038.py index 6e116034fe8010..093ad7cd1fb41c 100644 --- a/crates/ruff_linter/resources/test/fixtures/flake8_bugbear/B038.py +++ b/crates/ruff_linter/resources/test/fixtures/flake8_bugbear/B038.py @@ -1,9 +1,3 @@ -""" -Should emit: -B999 - on lines 11, 25, 26, 40, 46 -""" - - some_list = [1, 2, 3] for elem in some_list: print(elem) @@ -47,7 +41,6 @@ def __init__(self, ls): del a.some_list[2] # should error - some_list = [1, 2, 3] for elem in some_list: print(elem) @@ -57,19 +50,17 @@ def __init__(self, ls): some_list.sort() # should error some_list.reverse() # should error some_list.clear() # should error - some_list.extend([1,2]) # should error + some_list.extend([1, 2]) # should error some_list.insert(1, 1) # should error - some_list.pop(1) # should error - some_list.pop() # should error - some_list = 3 # should error + some_list.pop(1) # should error + some_list.pop() # should error + some_list = 3 # should error break - -mydicts = {'a': {'foo': 1, 'bar': 2}} +mydicts = {"a": {"foo": 1, "bar": 2}} for mydict in mydicts: - if mydicts.get('a', ''): - print(mydict['foo']) # should not error - mydicts.popitem() # should error - + if mydicts.get("a", ""): + print(mydict["foo"]) # should not error + mydicts.popitem() # should error diff --git a/crates/ruff_linter/src/rules/flake8_bugbear/snapshots/ruff_linter__rules__flake8_bugbear__tests__B038_B038.py.snap b/crates/ruff_linter/src/rules/flake8_bugbear/snapshots/ruff_linter__rules__flake8_bugbear__tests__B038_B038.py.snap index 4dd4a3105d7354..d6a5f341c7d42e 100644 --- a/crates/ruff_linter/src/rules/flake8_bugbear/snapshots/ruff_linter__rules__flake8_bugbear__tests__B038_B038.py.snap +++ b/crates/ruff_linter/src/rules/flake8_bugbear/snapshots/ruff_linter__rules__flake8_bugbear__tests__B038_B038.py.snap @@ -1,136 +1,136 @@ --- source: crates/ruff_linter/src/rules/flake8_bugbear/mod.rs --- -B038.py:11:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs - | - 9 | print(elem) -10 | if elem % 2 == 0: -11 | some_list.remove(elem) # should error - | ^^^^^^^^^^^^^^^^ B038 -12 | -13 | some_list = [1, 2, 3] - | +B038.py:5:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs + | +3 | print(elem) +4 | if elem % 2 == 0: +5 | some_list.remove(elem) # should error + | ^^^^^^^^^^^^^^^^ B038 +6 | +7 | some_list = [1, 2, 3] + | -B038.py:26:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:20:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -24 | print(elem) -25 | if elem % 2 == 0: -26 | del some_list[2] # should error +18 | print(elem) +19 | if elem % 2 == 0: +20 | del some_list[2] # should error | ^^^^^^^^^^^^^^^^ B038 -27 | del some_list +21 | del some_list | -B038.py:27:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:21:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -25 | if elem % 2 == 0: -26 | del some_list[2] # should error -27 | del some_list +19 | if elem % 2 == 0: +20 | del some_list[2] # should error +21 | del some_list | ^^^^^^^^^^^^^ B038 | -B038.py:41:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:35:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -39 | print(elem) -40 | if elem % 2 == 0: -41 | a.some_list.remove(elem) # should error +33 | print(elem) +34 | if elem % 2 == 0: +35 | a.some_list.remove(elem) # should error | ^^^^^^^^^^^^^^^^^^ B038 -42 | -43 | a = A((1, 2, 3)) +36 | +37 | a = A((1, 2, 3)) | -B038.py:47:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:41:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -45 | print(elem) -46 | if elem % 2 == 0: -47 | del a.some_list[2] # should error +39 | print(elem) +40 | if elem % 2 == 0: +41 | del a.some_list[2] # should error | ^^^^^^^^^^^^^^^^^^ B038 | -B038.py:56:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:49:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -54 | if elem == 2: -55 | found_idx = some_list.index(elem) # should not error -56 | some_list.append(elem) # should error +47 | if elem == 2: +48 | found_idx = some_list.index(elem) # should not error +49 | some_list.append(elem) # should error | ^^^^^^^^^^^^^^^^ B038 -57 | some_list.sort() # should error -58 | some_list.reverse() # should error +50 | some_list.sort() # should error +51 | some_list.reverse() # should error | -B038.py:57:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:50:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -55 | found_idx = some_list.index(elem) # should not error -56 | some_list.append(elem) # should error -57 | some_list.sort() # should error +48 | found_idx = some_list.index(elem) # should not error +49 | some_list.append(elem) # should error +50 | some_list.sort() # should error | ^^^^^^^^^^^^^^ B038 -58 | some_list.reverse() # should error -59 | some_list.clear() # should error +51 | some_list.reverse() # should error +52 | some_list.clear() # should error | -B038.py:58:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:51:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -56 | some_list.append(elem) # should error -57 | some_list.sort() # should error -58 | some_list.reverse() # should error +49 | some_list.append(elem) # should error +50 | some_list.sort() # should error +51 | some_list.reverse() # should error | ^^^^^^^^^^^^^^^^^ B038 -59 | some_list.clear() # should error -60 | some_list.extend([1,2]) # should error +52 | some_list.clear() # should error +53 | some_list.extend([1, 2]) # should error | -B038.py:59:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:52:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -57 | some_list.sort() # should error -58 | some_list.reverse() # should error -59 | some_list.clear() # should error +50 | some_list.sort() # should error +51 | some_list.reverse() # should error +52 | some_list.clear() # should error | ^^^^^^^^^^^^^^^ B038 -60 | some_list.extend([1,2]) # should error -61 | some_list.insert(1, 1) # should error +53 | some_list.extend([1, 2]) # should error +54 | some_list.insert(1, 1) # should error | -B038.py:60:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:53:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -58 | some_list.reverse() # should error -59 | some_list.clear() # should error -60 | some_list.extend([1,2]) # should error +51 | some_list.reverse() # should error +52 | some_list.clear() # should error +53 | some_list.extend([1, 2]) # should error | ^^^^^^^^^^^^^^^^ B038 -61 | some_list.insert(1, 1) # should error -62 | some_list.pop(1) # should error +54 | some_list.insert(1, 1) # should error +55 | some_list.pop(1) # should error | -B038.py:61:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:54:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -59 | some_list.clear() # should error -60 | some_list.extend([1,2]) # should error -61 | some_list.insert(1, 1) # should error +52 | some_list.clear() # should error +53 | some_list.extend([1, 2]) # should error +54 | some_list.insert(1, 1) # should error | ^^^^^^^^^^^^^^^^ B038 -62 | some_list.pop(1) # should error -63 | some_list.pop() # should error +55 | some_list.pop(1) # should error +56 | some_list.pop() # should error | -B038.py:62:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:55:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -60 | some_list.extend([1,2]) # should error -61 | some_list.insert(1, 1) # should error -62 | some_list.pop(1) # should error +53 | some_list.extend([1, 2]) # should error +54 | some_list.insert(1, 1) # should error +55 | some_list.pop(1) # should error | ^^^^^^^^^^^^^ B038 -63 | some_list.pop() # should error -64 | some_list = 3 # should error +56 | some_list.pop() # should error +57 | some_list = 3 # should error | -B038.py:63:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:56:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -61 | some_list.insert(1, 1) # should error -62 | some_list.pop(1) # should error -63 | some_list.pop() # should error +54 | some_list.insert(1, 1) # should error +55 | some_list.pop(1) # should error +56 | some_list.pop() # should error | ^^^^^^^^^^^^^ B038 -64 | some_list = 3 # should error -65 | break +57 | some_list = 3 # should error +58 | break | -B038.py:74:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs +B038.py:66:9: B038 editing a loop's mutable iterable often leads to unexpected results/bugs | -72 | if mydicts.get('a', ''): -73 | print(mydict['foo']) # should not error -74 | mydicts.popitem() # should error +64 | if mydicts.get("a", ""): +65 | print(mydict["foo"]) # should not error +66 | mydicts.popitem() # should error | ^^^^^^^^^^^^^^^ B038 |