Revert: [pyflakes] Avoid false positives in @no_type_check contexts (…

…F821, F722) (#14615)

crates/ruff_linter/src/checkers/ast/mod.rs

@@ -723,12 +723,6 @@ impl<'a> Visitor<'a> for Checker<'a> {
                 // Visit the decorators and arguments, but avoid the body, which will be
                 // deferred.
                 for decorator in decorator_list {
-                    if self
-                        .semantic
-                        .match_typing_expr(&decorator.expression, "no_type_check")
-                    {
-                        self.semantic.flags |= SemanticModelFlags::NO_TYPE_CHECK;
-                    }
                     self.visit_decorator(decorator);
                 }
 
@@ -1897,9 +1891,6 @@ impl<'a> Checker<'a> {
 
     /// Visit an [`Expr`], and treat it as a type definition.
     fn visit_type_definition(&mut self, expr: &'a Expr) {
-        if self.semantic.in_no_type_check() {
-            return;
-        }
         let snapshot = self.semantic.flags;
         self.semantic.flags |= SemanticModelFlags::TYPE_DEFINITION;
         self.visit_expr(expr);

crates/ruff_linter/src/rules/pyflakes/mod.rs

@@ -94,8 +94,7 @@ mod tests {
     #[test_case(Rule::YieldOutsideFunction, Path::new("F704.py"))]
     #[test_case(Rule::ReturnOutsideFunction, Path::new("F706.py"))]
     #[test_case(Rule::DefaultExceptNotLast, Path::new("F707.py"))]
-    #[test_case(Rule::ForwardAnnotationSyntaxError, Path::new("F722_0.py"))]
-    #[test_case(Rule::ForwardAnnotationSyntaxError, Path::new("F722_1.py"))]
+    #[test_case(Rule::ForwardAnnotationSyntaxError, Path::new("F722.py"))]
     #[test_case(Rule::RedefinedWhileUnused, Path::new("F811_0.py"))]
     #[test_case(Rule::RedefinedWhileUnused, Path::new("F811_1.py"))]
     #[test_case(Rule::RedefinedWhileUnused, Path::new("F811_2.py"))]
@@ -160,7 +159,6 @@ mod tests {
     #[test_case(Rule::UndefinedName, Path::new("F821_26.pyi"))]
     #[test_case(Rule::UndefinedName, Path::new("F821_27.py"))]
     #[test_case(Rule::UndefinedName, Path::new("F821_28.py"))]
-    #[test_case(Rule::UndefinedName, Path::new("F821_30.py"))]
     #[test_case(Rule::UndefinedExport, Path::new("F822_0.py"))]
     #[test_case(Rule::UndefinedExport, Path::new("F822_0.pyi"))]
     #[test_case(Rule::UndefinedExport, Path::new("F822_1.py"))]

crates/ruff_linter/src/rules/pyflakes/snapshots/ruff_linter__rules__pyflakes__tests__F722_F722_0.py.snap → crates/ruff_linter/src/rules/pyflakes/snapshots/ruff_linter__rules__pyflakes__tests__F722_F722.py.snap

@@ -2,14 +2,14 @@
 source: crates/ruff_linter/src/rules/pyflakes/mod.rs
 snapshot_kind: text
 ---
-F722_0.py:9:12: F722 Syntax error in forward annotation: `///`
+F722.py:9:12: F722 Syntax error in forward annotation: `///`
    |
  9 | def g() -> "///":
    |            ^^^^^ F722
 10 |     pass
    |
 
-F722_0.py:13:4: F722 Syntax error in forward annotation: `List[int]☃`
+F722.py:13:4: F722 Syntax error in forward annotation: `List[int]☃`
    |
 13 | X: """List[int]"""'☃' = []
    |    ^^^^^^^^^^^^^^^^^^ F722

crates/ruff_python_semantic/src/model.rs

@@ -1717,11 +1717,6 @@ impl<'a> SemanticModel<'a> {
         self.flags.intersects(SemanticModelFlags::ANNOTATION)
     }
 
-    /// Return `true` if the model is in a `@no_type_check` context.
-    pub const fn in_no_type_check(&self) -> bool {
-        self.flags.intersects(SemanticModelFlags::NO_TYPE_CHECK)
-    }
-
     /// Return `true` if the model is in a typing-only type annotation.
     pub const fn in_typing_only_annotation(&self) -> bool {
         self.flags
@@ -2403,22 +2398,6 @@ bitflags! {
         /// [PEP 257]: https://peps.python.org/pep-0257/#what-is-a-docstring
         const ATTRIBUTE_DOCSTRING = 1 << 25;
 
-        /// The model is in a [no_type_check] context.
-        ///
-        /// This is used to skip type checking when the `@no_type_check` decorator is found.
-        ///
-        /// For example (adapted from [#13824]):
-        /// ```python
-        /// from typing import no_type_check
-        ///
-        /// @no_type_check
-        /// def fn(arg: "A") -> "R":
-        ///     pass
-        /// ```
-        ///
-        /// [no_type_check]: https://docs.python.org/3/library/typing.html#typing.no_type_check
-        /// [#13824]: https://github.com/astral-sh/ruff/issues/13824
-        const NO_TYPE_CHECK = 1 << 26;
         /// The model is in the value expression of a [PEP 613] explicit type alias.
         ///
         /// For example: