From 1a2bd984f20fd71320d0d623e9b41da6687d93c6 Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Tue, 20 Jun 2023 19:01:21 -0400 Subject: [PATCH] Avoid `.unwrap()` on cache access (#5229) ## Summary I haven't been able to determine why / when this is happening, but in some cases, users are reporting that this `unwrap()` is causing a panic. It's fine to just return `None` here and fallback to "No cache", certainly better than panicking (while we figure out the edge case). Closes #5225. Closes #5228. --- crates/ruff_cli/src/commands/run.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crates/ruff_cli/src/commands/run.rs b/crates/ruff_cli/src/commands/run.rs index 9ff134f2c96d9..ac27ff15c9f8b 100644 --- a/crates/ruff_cli/src/commands/run.rs +++ b/crates/ruff_cli/src/commands/run.rs @@ -107,9 +107,7 @@ pub(crate) fn run( let settings = resolver.resolve_all(path, pyproject_config); let package_root = package.unwrap_or_else(|| path.parent().unwrap_or(path)); - let cache = caches - .as_ref() - .map(|caches| caches.get(&package_root).unwrap()); + let cache = caches.as_ref().and_then(|caches| caches.get(&package_root)); lint_path(path, package, settings, cache, noqa, autofix).map_err(|e| { (Some(path.to_owned()), {