Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deprecated huggingface_hub.cached_download #645

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

mattiadg
Copy link
Contributor

Fix #644
Removes the warning by following the upgrade instructions

@mpariente
Copy link
Collaborator

Thank you very much for the PR.

Have you tested it ?

In which version has the huggingface_hub.hf_hub_download been introduced ? Won't upgrading to it break asteroid's install for current users ?

@mattiadg
Copy link
Contributor Author

mattiadg commented Oct 24, 2022 via email

@mpariente
Copy link
Collaborator

Then it's perfect, thanks !

@mpariente mpariente merged commit 140733b into asteroid-team:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning cached_download deprecated
2 participants