Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beamforming modules #468

Merged
merged 7 commits into from
Apr 9, 2021
Merged

Add beamforming modules #468

merged 7 commits into from
Apr 9, 2021

Conversation

mpariente
Copy link
Collaborator

@mpariente mpariente commented Mar 26, 2021

This is inspired by the code in nn-gev from Paderborn and François Grondin's code in speechbrain.
Thanks for open-sourcing it.
Also helped by @popcornell for MWF

Left to code:

  • GCCPhat with quadratic interpolation (cf François Grondin's code)
  • steering vector
  • Blind analytic normalization
  • GEV vector phase correction

In parallel

  • More docs
  • Examples
  • Tests

Might be interesting for @boeddeker @FrancoisGrondin @faroit

@popcornell
Copy link
Collaborator

popcornell commented Mar 27, 2021

GCCPhat with quadratic interpolation (cf François Grondin's code).

We might want to do a Localization module for that.
Also, for tests, we can test against the numpy implementation by Padeborn or ESPNet one.

@mpariente
Copy link
Collaborator Author

Makes sense for the localisation, you're right.

By the way, eternal question, should we make a functional version, and module wrappers?
It might be easier to use for functional addicts

@popcornell
Copy link
Collaborator

Can you be more specific ?
Module wrappers you mean wrapping an STFT encoder module in the case of GCC-PHAT ?

@mpariente
Copy link
Collaborator Author

Sorry.

Currently, the beamforming code it's only accessible in nn.Modules.
In PyTorch, all ops are first implemented as functions, and then it also provides some class wrappers.

Should we outsource everything in functions, and only make the function calls in the class, so bothb usage are possible?

@mpariente
Copy link
Collaborator Author

/rebase

@mpariente mpariente marked this pull request as ready for review March 27, 2021 19:30
@mpariente
Copy link
Collaborator Author

@popcornell could you review please?

@mpariente mpariente merged commit 9d3f168 into master Apr 9, 2021
@mpariente mpariente deleted the beamforming branch April 9, 2021 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants