-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beamforming modules #468
Conversation
GCCPhat with quadratic interpolation (cf François Grondin's code). We might want to do a Localization module for that. |
Makes sense for the localisation, you're right. By the way, eternal question, should we make a functional version, and module wrappers? |
Can you be more specific ? |
Sorry. Currently, the beamforming code it's only accessible in nn.Modules. Should we outsource everything in functions, and only make the function calls in the class, so bothb usage are possible? |
/rebase |
@popcornell could you review please? |
This is inspired by the code in
nn-gev
from Paderborn and François Grondin's code in speechbrain.Thanks for open-sourcing it.
Also helped by @popcornell for MWF
Left to code:
In parallel
Might be interesting for @boeddeker @FrancoisGrondin @faroit