Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[src] Make sample rate positional #431

Merged
merged 4 commits into from
Feb 7, 2021
Merged

Conversation

mpariente
Copy link
Collaborator

As discussed in #427, we'll remove default sample rate argument.

We start with a deprecation warning when it is not passed, and will remove it in a later release.

@jonashaag
Copy link
Collaborator

Positional and having a default are orthogonal concepts. I think the wording should be: “will be required argument in the future.”

Also, is it safe to remove the backwards compat SR table lookups now? (I am not up to date on that front)

@mpariente
Copy link
Collaborator Author

Positional and having a default are orthogonal concepts. I think the wording should be: “will be required argument in the future.”

Thanks.
I was thinking about the wording and I was sure I messed it up 😉

Also, is it safe to remove the backwards compat SR table lookups now? (I am not up to date on that front)

No, the only model that has 16k FS is DeMask, which is not on HF's hub yet (@popcornell ? ^^)

@mpariente mpariente merged commit c0b673e into master Feb 7, 2021
@mpariente mpariente deleted the sample_rate_positional branch February 7, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants