-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wer tracker #414
Wer tracker #414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The estimates seem a bit off 😂 but this was clearly missing, thanks!
Haha the estimates are wrong because the model was trained on noisy inputs and the enhancement is making things worse... |
Let's include the wav normalization in the WERTracker class? |
What is the ID field in .json annotation ? |
We can but we have to do it anyway before saving the files in
In a general way the ID is something we introduced for librimix to match transcriptions and wav files . For this specific screen shot this annotation and ID's are taken from CHIME 4. ( I will open a PR soon) |
Maybe call em UtteranceID or ExampleID? Because we might need also speaker IDs |
Also, please make the fields in JSON all lower case: "text_0", "utt_id_0" etc... |
asteroid/metrics.py
Outdated
self.sample_rate = int(d.data_frame[d.data_frame["name"] == model_name]["fs"]) | ||
self.trans_df = trans_df | ||
self.trans_dic = self._df_to_dict(trans_df) | ||
self.mix_counter = Counter() | ||
self.clean_counter = Counter() | ||
self.est_counter = Counter() | ||
self.transformation = jiwer.Compose([jiwer.ToLowerCase(), jiwer.RemovePunctuation()]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this transformation enough?
The default is
[<jiwer.transforms.RemoveMultipleSpaces at 0x7fbc79a75df0>,
<jiwer.transforms.Strip at 0x7fbc79a75e20>,
<jiwer.transforms.SentencesToListOfWords at 0x7fbc79a75f10>,
<jiwer.transforms.RemoveEmptyStrings at 0x7fbc7aa17bb0>]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tested on CHIME4 these were the two that made a difference but you are right let's add the others. It doesn't cost that much anyway.
asteroid/metrics.py
Outdated
def all_transcriptions(self): | ||
return dict(transcriptions=self.transcriptions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really see the point of the dict with one field, returning the list.
I'd remove this method entirely
remove all_transcriptions method
/lint |
About this PR
The file containing the transcriptions is a
.json
that looks like this :