Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate version number #388

Merged
merged 3 commits into from
Dec 12, 2020
Merged

Deduplicate version number #388

merged 3 commits into from
Dec 12, 2020

Conversation

iver56
Copy link
Contributor

@iver56 iver56 commented Dec 10, 2020

@mpariente
Copy link
Collaborator

Thanks !

Could you push an empty commit please, the push build was not triggered because of the force push.

@mpariente
Copy link
Collaborator

Thanks ! It doesn't seem the push build got triggered, IDK why.
BTW, you can use --allow-empty to make a true empty commit.

LGTM, @jonashaag ?

mpariente
mpariente reviewed Dec 11, 2020
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@mpariente mpariente merged commit d735597 into asteroid-team:master Dec 12, 2020
@mpariente
Copy link
Collaborator

Thanks again!

@iver56 iver56 deleted the ij/dry-version branch December 12, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpariente mpariente mpariente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iver56 @mpariente