From 9c54781f895e15fd7fc5b5aa8f511bfdb671309b Mon Sep 17 00:00:00 2001
From: Assunta DeSanto <assuntad23@gmail.com>
Date: Thu, 7 Dec 2023 20:20:50 -0500
Subject: [PATCH] disabling button and adding tool tips, and simplifying logic
 in invocationStateSuccess function

---
 .../WorkflowInvocationSummary.vue             | 20 ++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/client/src/components/WorkflowInvocationState/WorkflowInvocationSummary.vue b/client/src/components/WorkflowInvocationState/WorkflowInvocationSummary.vue
index 867fb46b50ae..2a83a2a7a325 100644
--- a/client/src/components/WorkflowInvocationState/WorkflowInvocationSummary.vue
+++ b/client/src/components/WorkflowInvocationState/WorkflowInvocationSummary.vue
@@ -3,16 +3,18 @@
         <div v-if="invocationAndJobTerminal">
             <span>
                 <b-button
-                    v-if="invocationStateSuccess"
                     v-b-tooltip.hover
+                    :title="invocationStateSuccess ? reportTooltip : disabledReportTooltip"
+                    :disabled="!invocationStateSuccess"
                     size="sm"
                     class="invocation-report-link"
                     :href="invocationLink">
                     View Report
                 </b-button>
                 <b-button
-                    v-if="invocationStateSuccess"
                     v-b-tooltip.hover
+                    :title="invocationStateSuccess ? generatePdfTooltip : disabledPdfTooltip"
+                    :disabled="!invocationStateSuccess"
                     size="sm"
                     class="invocation-pdf-link"
                     :href="invocationPdfLink"
@@ -115,6 +117,12 @@ export default {
         return {
             stepStatesInterval: null,
             jobStatesInterval: null,
+            reportTooltip: "View report for this workflow invocation",
+            generatePdfTooltip: "Generate PDF report for this workflow invocation",
+            disabledReportTooltip:
+                "Unable to create report because this workflow invocation is not complete or was not successful.",
+            disabledPdfTooltip:
+                "Unable to generate PDF because this workflow invocation is not complete or was not successful.",
         };
     },
     computed: {
@@ -134,13 +142,15 @@ export default {
         },
         invocationStateSuccess: function () {
             return (
-                this.invocationState !== "failed" &&
-                this.invocationState !== "cancelled" &&
+                this.invocationState == "scheduled" &&
                 this.errorCount === 0 &&
                 this.runningCount === 0 &&
-                this.stepStates.scheduled === this.stepCount
+                this.invocationAndJobTerminal
             );
         },
+        displayTooltip: function () {
+            return this.invocationStateSuccess ? "" : this.disabledTooltip;
+        },
         stepCount: function () {
             return this.invocation?.steps.length;
         },