Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT2 pack update #269

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Conversation

akuzia
Copy link
Contributor

@akuzia akuzia commented Jan 24, 2024

Added new track and car group to frontend

@akuzia
Copy link
Contributor Author

akuzia commented Jan 24, 2024

Car group is not valid, server do not accept connections. strange.

Copy link

@Bloodsaw Bloodsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked cars and tracks.js against ServerAdminHandbook in dedicated server dir.
Found no typos or syntax errors and the ids are correct.

@Bloodsaw
Copy link

Bloodsaw commented Jan 24, 2024

Car group is not valid, server do not accept connections. strange.

Same here. Server comes up and is registered to lobby, but Car Group in UI shows as "unknown". Car selection however is correctly reduced to GT2 cargroup, cannot join either.
Since I cannot find any server in the lobby list with the GT2 filter it seems that its a bug in acc.
Its safe to assume that GT2 is the correct value here since the server is starting.

Edit:
Now its working, was some other setting in my test-system.
GT2 carGroup is working but showing incorrectly in acc GUI as "unknown", in serverlogs its fine though.
Connecting with GT2 car was possible.

Copy link

@Bloodsaw Bloodsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See latest comments.
From my tests these changes are indeed correct and working.

@pedrofaria
Copy link
Collaborator

Thanks so much for your PR...

Please, update CHANGELOG.md file with version 1.24.0 then we can merge it

@pedrofaria
Copy link
Collaborator

accweb_v1.24.0-rc1.zip

for community testing

@Bloodsaw
Copy link

accweb_v1.24.0-rc1.zip

for community testing

Also tested the rc1 build with track redbull ring and GT2 car class and a BoP for a GT2 car. Could connect to server.
Seems fine.

@pedrofaria
Copy link
Collaborator

Well I will merge and fix CHANGELOG myself

@pedrofaria pedrofaria changed the title Draft: GT2 pack update GT2 pack update Jan 24, 2024
@pedrofaria pedrofaria merged commit 97975f1 into assetto-corsa-web:master Jan 24, 2024
@akuzia akuzia deleted the GT2-pack-update branch January 25, 2024 06:15
@akuzia
Copy link
Contributor Author

akuzia commented Jan 25, 2024

Thank you for the fast responce. Running docker image tagged 1.24.0 version 1.22.4 showed in interface and no changes to event form are applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants