Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: only make diffImage when the images don't match #75

Closed
jpratt2 opened this issue Jun 29, 2020 · 1 comment
Closed

suggestion: only make diffImage when the images don't match #75

jpratt2 opened this issue Jun 29, 2020 · 1 comment

Comments

@jpratt2
Copy link
Contributor

jpratt2 commented Jun 29, 2020

As a suggestion, I suggest that the diff image doesn't need to be created unless there is a difference.
Currently, this will create a diffImage.png every time, even if there is no difference.
//Shutterbug.shootPage(driver,ScrollStrategy.WHOLE_PAGE).equalsWithDiff(expectedImage,"observed\diffImage");

@glibas glibas closed this as completed in 7e44278 Jun 30, 2020
@jpratt2
Copy link
Contributor Author

jpratt2 commented Jun 30, 2020

Thank you for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant