WebSocket Middleware considers Connection: keep-alive, upgrade as non-WebSocket request

[analogrelay]

Firefox sends it's WebSocket upgrade request with a Connection header value of keep-alive, Upgrade. But we check for the header to exactly equal Upgrade.

WebSockets/src/Microsoft.AspNetCore.WebSockets/Internal/HandshakeHelpers.cs

Line 38 in 4e2ecf8

if (string.Equals(Constants.Headers.ConnectionUpgrade, pair.Value, StringComparison.OrdinalIgnoreCase))

Similar to aspnet/KestrelHttpServer#1170

[analogrelay]

Ping @muratg for Triage. I assume 1.1.0 RTM for now.

[Tratcher]

This implementation is actually OK. See

WebSockets/src/Microsoft.AspNetCore.WebSockets/WebSocketMiddleware.cs

Line 78 in 4e2ecf8

foreach (var value in _context.Request.Headers.GetCommaSeparatedValues(headerName))

where it splits the header values.

This is only blocked by the kestrel issue. It works with WebListener.

[muratg]

Closing based on @Tratcher's input.