Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

Add/Update logging in static files middleware #69

Closed
rynowak opened this issue Sep 24, 2015 · 4 comments
Closed

Add/Update logging in static files middleware #69

rynowak opened this issue Sep 24, 2015 · 4 comments
Assignees
Milestone

Comments

@rynowak
Copy link
Member

rynowak commented Sep 24, 2015

From offline logging discussion:

Add Verbose logging where it can be useful for debugging

  • Time box to 2 dev-days maximum (across all of k-core)
  • Use EventIds at each logging statement
  • Update any existing logging to include an EventId

Relevant logging points we want to include for sure:

        - Served a file - Information
        - Did not serve a file
@rynowak
Copy link
Member Author

rynowak commented Sep 24, 2015

/cc @muratg

@rynowak rynowak closed this as completed Sep 24, 2015
@rynowak rynowak reopened this Sep 24, 2015
@muratg
Copy link

muratg commented Sep 24, 2015

@Tratcher Looks like a good suggestion. Want to take a stab at very early RC1?

@Tratcher
Copy link
Member

Did not serve a file would fire for almost every request, sounds like it should be verbose or debug. @rynowak Any examples of work already done that uses EventIds?

@Tratcher Tratcher added this to the 1.0.0-rc1 milestone Sep 24, 2015
@Tratcher Tratcher self-assigned this Sep 24, 2015
@Tratcher Tratcher added the bug label Sep 24, 2015
@rynowak
Copy link
Member Author

rynowak commented Sep 24, 2015

Yes, not-serving a file would be Verbose.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants