Skip to content
This repository has been archived by the owner on Nov 29, 2018. It is now read-only.

Port "Tool produces a 0-byte binary when compilation fails" to 1.1.1 #40

Closed
pranavkm opened this issue Nov 23, 2016 · 5 comments
Closed

Port "Tool produces a 0-byte binary when compilation fails" to 1.1.1 #40

pranavkm opened this issue Nov 23, 2016 · 5 comments
Assignees
@pranavkm
Labels
bug duplicate
Milestone
1.1.0

Comments

@pranavkm
Copy link
Contributor

Original issue #35
@pranavkm
Copy link
Contributor Author

pranavkm commented Nov 23, 2016 •
edited
Loading

cc @Eilon \ @DamianEdwards \ @rynowak

@Eilon Eilon added this to the 1.1.1 milestone Nov 23, 2016
@Eilon
Copy link
Member

Eilon commented Jan 19, 2017

This patch bug is approved. Please use the normal code review process w/ a PR and make sure the fix is in the correct branch, then close the bug and mark it as done.

@pranavkm
Copy link
Contributor Author

Do we plan on releasing a project.json targeting update for the tool? Or is the plan to roll this fix in with the 1.1.0 RTM build of the package that targets csproj?

@Eilon Eilon modified the milestones: 1.1.0, 1.1.1 Jan 19, 2017
@Eilon
Copy link
Member

Eilon commented Jan 19, 2017

Yeah, taking this out of the "patch" list because we can just do it in the RTM build of this, which hasn't shipped yet.

@pranavkm
Copy link
Contributor Author

We don't have to do anything here. The fix is already part of the 1.1.0 release so this can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
bug duplicate
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@pranavkm @Eilon