Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Commit cache entries only when the content gets successfully generated #6522

Closed
javiercn opened this issue Jul 10, 2017 · 0 comments
Closed

Commit cache entries only when the content gets successfully generated #6522

javiercn opened this issue Jul 10, 2017 · 0 comments
Assignees
@javiercn
Labels
3 - Done bug
Milestone
2.0.0

Comments

@javiercn
Copy link
Member

https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.TagHelpers/CacheTagHelper.cs#L113

The using will call Dispose when the generation of the content throws and that will incorrectly commit the entry.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@javiercn javiercn

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@javiercn