Consider using DisplayAttribute.GroupName to determine SelectListItem's Group

[pranavkm]

IHtmlHelper.GetEnumSelectList picks up DisplayAttribute.Name to determine an enum field's display name. It seems appropriate for it also pick up DispayAttribute.GroupName to group these enum values.

That said, this might have pretty narrow scope - there aren't too many scenarios I can think of where the values used to produce SelectListItem are annotated to start with.

[dougbu]

low priority, I agree. but we pay attention to [Display(Name=x)], so why not [Display[GroupName=y)] as well?

[heathyates]

@danroth27 @henkmollema Is this issue closed?

[henkmollema]

@heathyates nope, my commit is just some try-out which got pushed accidentally.

[stebet]

So. I have this working pretty well on my fork. It displays groups depending on the GroupName in the DisplayAttribute, by default groups and non-groups are just displayed in the order they are reflected form the Attribute (no sorting by group name or item name by default, thought that could rather be done manually since the Html.GetEnumSelectList returns an IEnumerable). Here is a small screenshot:

Anything else that needs to be added or changed before I send in a pull request?

[pranavkm]

Looks good to me.

[stebet]

I'll send in the pull request so we can continue the discussion from a code perspective then :)

[dougbu]

@Eilon wanna have this in Beta 8? @stebet is wrapping up #3201 as we speak.

[Eilon]

Beta8 is closed. For RC this will be fine.

[dougbu]

🆗 self-assigning since I've been working with @stebet on #3201

[dougbu]

13af6f8

[dougbu]

Thanks @stebet !