Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

Automatic inclusion of sqlite3.dll for UWPs defeats the purpose of WinSqlite. #260

Closed
ali-hk opened this issue Jun 2, 2016 · 3 comments
Closed

Comments

@ali-hk
Copy link

ali-hk commented Jun 2, 2016

Currently if the rc2 nuget package is referenced from a UWP, it automatically includes a copy of sqlite3.dll in the AppX package. This pretty much defeats one of the primary purposes of WinSqlite, which is to reduce app package size and reduce the number of times sqlite3.dll is present in various apps.
One potential solution to this is to check for an MSBuild property (say DisableIncludeSqlite) and check if that's set in the targets file, and if so don't include it.

This would also enable developers to provide custom (perhaps newer) builds of sqlite3.dll if needed.

@bricelam
Copy link
Contributor

bricelam commented Jun 2, 2016

We're discussing possible solutions to this as part of #148

@bricelam
Copy link
Contributor

bricelam commented Jun 2, 2016

For now, you can remove it by adding the following to your *.csproj file.

<Target Name="RemoveSqlite" AfterTargets="ResolveNuGetPackageAssets">
  <ItemGroup>
    <ReferenceCopyLocalPaths Remove="%(ReferenceCopyLocalPaths.Identity)"
                             Condition="'%(Filename)%(Extension)' == 'sqlite3.dll' " />
  </ItemGroup>
</Target>

Unfortunately, .NET Native takes issue with this. (See #249)

@divega
Copy link

divega commented Jun 8, 2016

Closing as this is covered by #148 and #249.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants