Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

Angular CLI-based template #1420

Closed
chamikasandamal opened this issue Dec 7, 2017 · 7 comments
Closed

Angular CLI-based template #1420

chamikasandamal opened this issue Dec 7, 2017 · 7 comments

Comments

@chamikasandamal
Copy link

Shall we communicate with angular team officially and make a common template by involving both teams.
I can see angular has their own suggestion here
https://github.com/angular/universal/tree/master/modules/aspnetcore-engine

and aspnet team trying to create new template here
#1288

It would be great if we can combine and share the effort.

@naveedahmed1
Copy link

With new Angular CLI based template aspnetcore-engine is not required any more and may ultimately be discontinued.

@chamikasandamal
Copy link
Author

@naveedahmed1: I think you are talking about aspnet-prerendering and not aspnetcore-engine

@naveedahmed1
Copy link

I am referring to aspnetcore-engine , aspnet-prerendering would still be required.

Did you get a chance to look at new template? It still uses aspnet-prerendering but doesn't depend on aspnetcore-engine.

@chamikasandamal
Copy link
Author

@naveedahmed1: are you referring angular universal template or #1288
in aspnet spa templates even in angular 4 version, i didn't saw any dependencies on aspnetcore-engine. what i'm thinking is why we can't make common version which both teams can work and recommend.

@naveedahmed1
Copy link

I am referring to #1288 which is now aligned with Angular CLI.

@SteveSandersonMS
Copy link
Member

Shall we communicate with angular team officially and make a common template by involving both teams.

Updating to an Angular CLI-based template means we now do have a common template, because the one included in the .NET SDK is directly equivalent to the one produced by Angular CLI by design.

@chamikasandamal
Copy link
Author

@SteveSandersonMS : But in angular site, they are referring to some other sample with aspnetcore-engine

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants