Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Port ChangePhoneNumber fix to 2.0.1 #1395

Closed
HaoK opened this issue Aug 25, 2017 · 7 comments
Closed

Port ChangePhoneNumber fix to 2.0.1 #1395

HaoK opened this issue Aug 25, 2017 · 7 comments

Comments

@HaoK
Copy link
Member

HaoK commented Aug 25, 2017

Port #1388

Change: b7d5a46

@HaoK HaoK added this to the 2.0.1 milestone Aug 25, 2017
@kinosang
Copy link

kinosang commented Sep 10, 2017

I wanna to know when will this patch releases?

or should I use the nightly build before you publish it?

@Eilon
Copy link
Member

Eilon commented Sep 18, 2017

This patch bug is approved for the 2.0.x patch. Please send a PR to the feature/2.0.1 branch and get it reviewed and merged. When we have the rel/2.0.1 branches ready please port the commit to that branch.

@Eilon
Copy link
Member

Eilon commented Sep 18, 2017

@kinosang we're working on setting up a feed for the upcoming 2.0.x patch that will have this fix.

@HaoK
Copy link
Member Author

HaoK commented Sep 18, 2017

Pushed b7d5a46 to feature/2.0.1

@HaoK HaoK added the 3 - Done label Sep 18, 2017
@HaoK HaoK closed this as completed Sep 22, 2017
@Eilon
Copy link
Member

Eilon commented Oct 23, 2017

Hi, we have a public test feed that you can use to try out the ASP.NET/EF Core 2.0.3 patch!

To try out the pre-release patch, please refer to the following guide:

We are looking for feedback on this patch. We'd like to know if you have any issues with this patch by updating your apps and libraries to the latest packages and seeing if it fixes the issues you've had, or if it introduces any new issues. If you have any issues or questions, please reply on this issue to let us know as soon as possible.

Thanks,
Eilon

@kevinchalet
Copy link

Erf, this "patch" introduces a terribad regression: it's no longer possible to create a custom provider for the "phone number tokens" as GenerateChangePhoneNumberTokenAsync() now directly calls the internal Rfc6238AuthenticationService class instead of the usual providers thingy.

Why was it fixed this way?

@blowdart
Copy link
Member

@HaoK was this deliberate?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants