Microsoft.Web.Xdt

[chucklu]

Hi team,
I find a library on nuget https://www.nuget.org/packages/Microsoft.Web.Xdt/2.1.2
The project site is https://xdt.codeplex.com.

Source Code
You can browse the source code via the web or use git to clone the source repository.
git clone https://git01.codeplex.com/xdt

when I try to clone it, but failed with following info:

fatal: unable to update url base from redirection:
asked for: https://git01.codeplex.com/xdt/info/refs?service=git-upload-pack
redirect: https://archive.codeplex.com/?p=git01

Could you tell me the correct url?

I find a fork on github https://github.com/davidalpert/xdt. but it's not the latest version released two months ago.
Is it possible for you to publish this project on github https://github.com/aspnet

[Tratcher]

@glennc @vijayrkn

[chucklu]

@glennc @vijayrkn
I want to report a bug about No element in the source document matches '/configuration/appSettings'
which happened in xdt\XmlTransform\XmlTransforms.cs
SiblingElement property of InsertBase class

The bug occurred when the base source have an xml namespace while the target remove it.
The patch file apply to the source like this,

<configuration xmlns="http://schemas.microsoft.com/.NetConfiguration/v2.0" xdt:Transform="RemoveAttributes(xmlns)" xmlns:xdt="http://schemas.microsoft.com/XML-Document-Transform">

I am not sure when you remove the namespace from source(maybe in memory), but when I remove the namespace from source, the exception disappeared.

[chucklu]

@glennc @vijayrkn
You can check the detail info here

[chucklu]

Hi,
@Tratcher @glennc @vijayrkn Anyone knows something about this issue?

[vijayrkn]

@chucklu - I will take a look at the issue you mentioned and will get back.

[chucklu]

Hi @vijayrkn , any progress?
Can you reproduce this issue reported on CameronWills/FatAntelope#6?
I guess when the patch file contains remove namespace, you remove it first.
Then XmlNodeList siblings = TargetNode.SelectNodes(xpath); can not find the node cause the namespace already removed.

[chucklu]

@vijayrkn any update?
I have found bug in AttributeTransform class

private XmlNodeList GetAttributesFrom(XmlNode node, IList<string> arguments, bool warnIfEmpty) {
            string[] array = new string[arguments.Count];
            arguments.CopyTo(array, 0);
            string xpath = String.Concat("@", String.Join("|@", array));
            
            XmlNodeList attributes = node.SelectNodes(xpath);
            if (attributes.Count == 0 && warnIfEmpty) {
                Debug.Assert(arguments.Count == 1, "Should only call warnIfEmpty==true with one argument");
                if (arguments.Count == 1) {
                    Log.LogWarning(SR.XMLTRANSFORMATION_TransformArgumentFoundNoAttributes, arguments[0]);
                }
            }

            return attributes;
        }

XmlNodeList attributes = node.SelectNodes(xpath);
The SelectNodes did not consider the node could have xmlnamespace.

[chucklu]

The node above is a target node, however when you record the log,
The CurrentReferenceNode is a transform node
Log.LogWarning(SR.XMLTRANSFORMATION_TransformArgumentFoundNoAttributes, arguments[0]);

public void LogWarning(string message, params object[] messageArgs) {
            if (SupressWarnings)
            {
                // SupressWarnings downgrade the Warning to LogMessage
                LogMessage(message, messageArgs);
            }
            else
            {
                if (CurrentReferenceNode != null)
                {
                    LogWarning(CurrentReferenceNode, message, messageArgs);
                }
                else if (externalLogger != null)
                {
                    externalLogger.LogWarning(message, messageArgs);
                }
            }
        }

[Eilon]

Closing this issue because this is not part of ASP.NET Core.

[chucklu]

Hi @Eilon, who I supposed to contact?

[Eilon]

@vijayrkn - what is the recommended place to report issues with XDT?

[vijayrkn]

At this point, aspnet/websdk would be the best place.

[Eilon]

Here's the full link: https://github.com/aspnet/websdk/issues