Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Can_use_with_fanned_relationships has incorrect assertion #10971

Closed
smitpatel opened this issue Feb 14, 2018 · 4 comments
Closed

Test: Can_use_with_fanned_relationships has incorrect assertion #10971

smitpatel opened this issue Feb 14, 2018 · 4 comments
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
2.1.0

Comments

@smitpatel
Copy link
Contributor

smitpatel commented Feb 14, 2018 •
edited
Loading

Can_use_with_fanned_relationships ignores a relationship but the seed data still contains connected data so when we load data from database and assert, it fails.
@smitpatel
Copy link
Contributor Author

smitpatel commented Feb 14, 2018 •
edited
Loading

Query_when_group_by throws client eval warning. Need to add a relational fixture to ignore client eval warning.

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Feb 15, 2018 •
edited
Loading

Also add a test for multiple identifying FKs where the principal types are siblings and another test where one of the principal types is assignable to the other.

@ajcvickers ajcvickers added this to the 2.1.0 milestone Feb 16, 2018
@smitpatel
Copy link
Contributor Author

Can_query_shared_derived has incomplete data.

@smitpatel
Copy link
Contributor Author

Also F1Fixture also has TitleSponsor has Owned navigation Details

AndriySvyryd added a commit that referenced this issue Feb 23, 2018
@AndriySvyryd
Enforce the dependent requiredness for table splitting more strictly
4dd1310 
Remove discriminator column if all derived types ignored
Fix table splitting tests

Fixes #10962
Fixes #10971
AndriySvyryd added a commit that referenced this issue Feb 23, 2018
@AndriySvyryd
Enforce the dependent requiredness for table splitting more strictly
8bc8ae2 
Remove discriminator column if all derived types ignored
Fix table splitting tests

Fixes #10962
Fixes #10971
@AndriySvyryd AndriySvyryd mentioned this issue Feb 23, 2018
Merged
AndriySvyryd added a commit that referenced this issue Feb 23, 2018
@AndriySvyryd
Enforce the dependent requiredness for table splitting more strictly
3ab14a2 
Remove discriminator column if all derived types ignored
Fix table splitting tests

Fixes #10962
Fixes #10971
@AndriySvyryd AndriySvyryd removed their assignment Feb 23, 2018
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 23, 2018
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview2, 2.1.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
3 participants
@ajcvickers @smitpatel @AndriySvyryd