Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: we inject redundant MaterializeCollectionNavigation calls into some queries that take advantage of correlated collection optimizations #10733

Closed
maumar opened this issue Jan 19, 2018 · 2 comments
Closed

Query: we inject redundant MaterializeCollectionNavigation calls into some queries that take advantage of correlated collection optimizations #10733

maumar opened this issue Jan 19, 2018 · 2 comments
Assignees
@maumar
Labels
area-perf closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
2.1.0

Comments

@maumar
Copy link
Contributor

maumar commented Jan 19, 2018

During nav rewrite, if we see "naked" collection navigation we inject MaterializeCollectionNavigation call. However, later in the pipeline we can optimize some of those collections using with the CorrelateSubquery pattern. CorrelateSubquery performs materialization itself, so the outer MaterializeCollectionNavigation call is no longer needed.
@maumar
Copy link
Contributor Author

maumar commented Jan 19, 2018

example: ComplexNavigationsQueryTestBase.Project_collection_and_root_entity

@maumar maumar self-assigned this Jan 19, 2018
@ajcvickers ajcvickers added this to the Backlog milestone Jan 22, 2018
@maumar maumar modified the milestones: Backlog, 2.1.0 Jan 24, 2018
@maumar
Copy link
Contributor Author

maumar commented Jan 24, 2018

fixed in 53dbe80

@maumar maumar closed this as completed Jan 24, 2018
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jan 24, 2018
@maumar maumar mentioned this issue Jan 24, 2018
Closed
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview2, 2.1.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-perf closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@ajcvickers @maumar