Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change parameter log formatting to not show DbType = String when it isn't #10634

Closed
ajcvickers opened this issue Jan 2, 2018 · 0 comments
Closed

Change parameter log formatting to not show DbType = String when it isn't #10634

ajcvickers opened this issue Jan 2, 2018 · 0 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-enhancement
Milestone
2.1.0

Comments

@ajcvickers
Copy link
Contributor

A DbType of String is sometimes set as the default by ADO.NET code--specifically tested with SQLClient. However, this doesn't actually mean that the type of the data is String, especially for nulls. We should change the formatting code to no show DbType = String when there is no real evidence that it actually is a string.
@ajcvickers ajcvickers self-assigned this Jan 3, 2018
@ajcvickers ajcvickers added this to the 2.1.0 milestone Jan 3, 2018
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview1, 2.1.0 Jan 17, 2018
ajcvickers added a commit that referenced this issue Feb 15, 2018
@ajcvickers
Change parameter log formatting to not show DbType = String when it i…
8e2e7b3 
…sn't

And show AnsiString when we know it is.

Issue #10634
@ajcvickers ajcvickers mentioned this issue Feb 15, 2018
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Feb 15, 2018
ajcvickers added a commit that referenced this issue Feb 16, 2018
@ajcvickers
Change parameter log formatting to not show DbType = String when it i…
808b443 
…sn't

And show AnsiString when we know it is.

Issue #10634
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview2, 2.1.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-enhancement
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
1 participant
@ajcvickers