Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BuiltInDataType tests to ensure batching case is covered #10633

Closed
ajcvickers opened this issue Jan 2, 2018 · 0 comments
Closed

Update BuiltInDataType tests to ensure batching case is covered #10633

ajcvickers opened this issue Jan 2, 2018 · 0 comments
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
2.1.0

Comments

@ajcvickers
Copy link
Contributor

Since we do not now batch for small numbers of entities it means that the tests that are intended to execise these paths actually use the non-batching paths. Tests should probably change min batch size.
@ajcvickers ajcvickers changed the title Update BuildInDataType tests to ensure batching case is covered Update BuiltInDataType tests to ensure batching case is covered Jan 2, 2018
@ajcvickers ajcvickers self-assigned this Jan 3, 2018
@ajcvickers ajcvickers added this to the 2.1.0 milestone Jan 3, 2018
ajcvickers added a commit that referenced this issue Jan 11, 2018
@ajcvickers
Allow mapping sql_variant on SQL Server
fcab5f1 
Issue #7043

The type mapper will now map properties to sql_variant columns if:
* The property is type object
* The store type name is specified as sql_variant

Also #10633 - set min batch size to 1 for type mapping tests so that batching and non-batching are tested.
@ajcvickers ajcvickers mentioned this issue Jan 11, 2018
Merged
ajcvickers added a commit that referenced this issue Jan 12, 2018
@ajcvickers
Allow mapping sql_variant on SQL Server
96e186b 
Issue #7043

The type mapper will now map properties to sql_variant columns if:
* The property is type object
* The store type name is specified as sql_variant

Also #10633 - set min batch size to 1 for type mapping tests so that batching and non-batching are tested.
ajcvickers added a commit that referenced this issue Jan 12, 2018
@ajcvickers
Allow mapping sql_variant on SQL Server
94b4932 
Issue #7043

The type mapper will now map properties to sql_variant columns if:
* The property is type object
* The store type name is specified as sql_variant

Also #10633 - set min batch size to 1 for type mapping tests so that batching and non-batching are tested.
ajcvickers added a commit that referenced this issue Jan 12, 2018
@ajcvickers
Allow mapping sql_variant on SQL Server
641b571 
Issue #7043

The type mapper will now map properties to sql_variant columns if:
* The property is type object
* The store type name is specified as sql_variant

Also #10633 - set min batch size to 1 for type mapping tests so that batching and non-batching are tested.
@ajcvickers ajcvickers added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. area-test labels Jan 12, 2018
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview1, 2.1.0 Jan 17, 2018
@ajcvickers ajcvickers modified the milestones: 2.1.0-preview2, 2.1.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
1 participant
@ajcvickers