Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing a property from modified to unchanged should reject changes #5645

Closed
ajcvickers opened this issue Jun 3, 2016 · 0 comments
Closed

Changing a property from modified to unchanged should reject changes #5645

ajcvickers opened this issue Jun 3, 2016 · 0 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
1.0.0

Comments

@ajcvickers
Copy link
Contributor

Looking through TODOs in the code I found one referencing issue #742 which is about rejecting changes to properties when they are marked as unchanged after having been modified. The issue was closed as being fixed, but it appears that it only got fixed when the whole entity is marked as unchanged, not when an individual property is marked as such, hence the remaining TODO in the code.

It seems inconsistent to have marking the entity work in one way but marking the property work the other way. I think we should fix this before RTM so that it isn't a breaking change post RTM.
ajcvickers added a commit that referenced this issue Jun 3, 2016
@ajcvickers
Rejecting changes when marking a property as not modified
89663bf 
Issue #5645
@ajcvickers ajcvickers mentioned this issue Jun 3, 2016
Merged
ajcvickers added a commit that referenced this issue Jun 3, 2016
@ajcvickers
Rejecting changes when marking a property as not modified
b3a18b2 
Issue #5645
@ajcvickers ajcvickers added this to the 1.0.0 milestone Jun 3, 2016
@ajcvickers ajcvickers self-assigned this Jun 3, 2016
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@ajcvickers