-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest RC2 packages do not install in latest UWP builds #4802
Comments
/cc @ericstj is doing some work in this area |
Yeah, we know latest is broken. UWP should only be using the stable meta-package until that work is done. |
Figured as much, just opened this to track making sure everything works on our side once things stabilize - the last few releases we've had to do additional work in our packages once everything under us is working. |
EF doesn't even work against the stable meta-package either. @ericstj What version of Ms.NETCore.UWP should we ensure works for RC2? |
No update yet. Still blocked on packaging issues in .NET Core (using rc2 build 23931). |
Can install EF.SQLite now with Ms.NetCore.UWP 5.2.0-rc2-*, but UWP is still broken. Blocked on https://github.com/dotnet/corefx/issues/7582 Still cannot install with Ns.NetCore.UWP 5.1.0 |
Are we intentionally leaving out runtime assemblies for UWP in RC2 from these BCL libraries? Or is this nuget installer error? Using rc2-23931, the following BCL nupkgs are missing runtime assemblies for UWP, which causes installing EF to fail against UWP 5.1.0
|
That's happening because you're upgrading all those packages which have been split between ref/lib without bringing in the lineup that pulls in the lib packages. I'd expect the latest 5.2.0 rc3 UWP meta-package to work. |
Alternatively, just bringing in the MS.NETCore.Platforms latest may solve the problem, but I believe you'll hit a couple other issues in the RC2 packages for UWP that have only been fixed in the RC3 branch (eg: AppContext, Linq.Expressions). |
So, then for the sake of our RC2 release, we should make sure we pull in stable packages in UWP 5.1.0. I believe this implies we will need to cross-compile, as we did for RC1. |
I think that's still the safest thing to do. As before you don't actually need to cross compile but just have a separate dependency set but if you're using project.json > pack you have to cross compile. |
What would it take to get these in RC2? cc @Eilon @davidfowl |
@natemcmaster I think at this point I'd do the cross compilation, because we know it will work. |
I'm not so sure it will. It did for RC1, but I've not yet been able to craft the right project.json's to make dotnet-restore, dotnet-pack, UWP, and EF happy together. |
I'm beginning to fear we may not be able to get this working for RC2 💀. I found the magic project.json a user needs to get packages to install AND to get build working. Nota bene: order matters
Result json: {
"dependencies": {
"Microsoft.EntityFrameworkCore.Sqlite": "1.0.0-rc2-20507",
"Microsoft.NETCore.Platforms": "1.0.1-rc2-23931",
"Microsoft.NETCore.UniversalWindowsPLatform": "5.1.0",
"Microsoft.Win32.Primitives": "4.0.1-rc2-23931",
"System.Diagnostics.Tools": "4.0.1-rc2-23931",
"System.Globalization.Calendars": "4.0.1-rc2-23931",
"System.Net.Sockets": "4.1.0-rc2-23931",
"System.Reflection.Emit.ILGeneration": "4.0.0",
"System.Threading.Timer": "4.0.1-rc2-23931"
},
"frameworks": {
"uap10.0": {}
},
"runtimes": {
"win10-arm": {},
"win10-arm-aot": {},
"win10-x86": {},
"win10-x86-aot": {},
"win10-x64": {},
"win10-x64-aot": {}
}
} |
Why are you updating the following? |
Platforms: #4802 (comment) |
That previous comment was about trying to use the latest packages in UWP. I thought we had switched gears to use stable dependencies for UWP. I would have expected you to do something like the following, like was done in RC1: |
Yes good point. I should have been more clear. Allow me to clarify. Approach 1: get EF working with RC2 .NET Core. I think it's clear at this point that approach isn't going to work. My comment here #4802 (comment) was regarding that first approach. Approach 2: cross-compile to lower dependencies for UWP. My comment #4802 (comment) was regarding cross-compiling to stable packages. Going forward: I'm working on approach 2 now. Status: cross-compiling isn't working (yet). |
Cross compiling to fix this issue. See PR #5021 |
Fixed #5021 |
🎉 |
Mark as Done? |
Marked. |
The errors are currently in our dependencies, so there is likely nothing to do on our side other than test and report issues to the appropriate teams. I've reported the current issue with the
System.AppContext
package to .NET Core folks.The text was updated successfully, but these errors were encountered: