-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easy to create a provider configured ModelBuilder #3529
Comments
Discussed in triage and decided we should have ModelBuilder factories so that folks don't need to worry about conventions etc. (especially since conventions are 'internal' for the first release). Folks can just create one up like this (note this is a static
Alternatively, if you want it to get all it's services from DI then we'll register one that you can just resolve... then you will get the same logger, etc. that is registered in DI (plus if you have overridden the type mapper etc. then you will also get those services).
|
BTW when we do this we should consider making convention sets internal too. I know providers might use them... but that is ok, it just means they aren't guaranteed to be stable between releases. |
One scenario we want to support is external model creation via ModelBuilder. However, it is currently difficult to get a ModelBuilder instance that has been configured with a provider specific convention set.
cc @sebastienros
The text was updated successfully, but these errors were encountered: