Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevEng: Scaffolding fails silently on VB projects #3417

Closed
ErikEJ opened this issue Oct 13, 2015 · 5 comments
Closed

RevEng: Scaffolding fails silently on VB projects #3417

ErikEJ opened this issue Oct 13, 2015 · 5 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@ErikEJ
Copy link
Contributor

ErikEJ commented Oct 13, 2015

It would be helpful to show an error message instead ErikEJ/EntityFramework.SqlServerCompact#242 (comment)

@rowanmiller
Copy link
Contributor

We should just be generating C# (or a warning would be fine too).

@lajones
Copy link
Contributor

lajones commented Dec 15, 2015

@rowanmiller @ErikEJ - I tried running Scaffold-DbContext against a VB project with build 7.0.0-rc2-16542 and that does not fail. Instead it produces C# code in the VB project successfully. So if we want that functionality we just leave the code as is. However I have created a PR, see #4087, which does throw an error from Scaffold-DbContext if the user attempts to run it from a VB project, which we can use if preferred.

@rowanmiller
Copy link
Contributor

Showing an error is better... so lets get your PR in

@lajones
Copy link
Contributor

lajones commented Dec 15, 2015

See comments in PR #4087. We decided to leave the code as is - for now it will generate C# code in a VB project.

@marcioqmaciel
Copy link

#4210

Migrations and Scaffold "translated" to VB.

@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-rc2, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

No branches or pull requests

5 participants