Skip to content
This repository has been archived by the owner on Oct 17, 2018. It is now read-only.

Can old storage in XML repositories be cleaned up? #158

Closed
hotchkj opened this issue Jun 7, 2016 · 2 comments
Closed

Can old storage in XML repositories be cleaned up? #158

hotchkj opened this issue Jun 7, 2016 · 2 comments
Milestone

Comments

@hotchkj
Copy link

hotchkj commented Jun 7, 2016

Apologies if this has been covered in earlier issues, but I couldn't find a good reference in the docs or here. If one is implementing IXmlRepository (I'm writing one to use AWS S3), it essentially has two calls - GetAllElements and StoreElement.

  • What's the right thing to do as this operates over time, to avoid unbounded disk/database/storage usage?
  • When can old elements be cleaned up, if at all?
  • Is this better done in GetAll or Store or asynchronously?

Thanks in advance.

@muratg muratg added this to the Discussions milestone Jun 9, 2016
@muratg
Copy link

muratg commented Jun 9, 2016

@blowdart Something we should consider. I don't think we have a clean-up story. Files are not huge so shouldn't be a big problem in the short-medium term.

@blowdart
Copy link
Member

blowdart commented Jun 9, 2016

No we shouldn't. This is on purpose. If you delete keys then any data that is encrypted with them can no longer be decrypted. As we don't know what users have done with keys, and any data is still available we cannot do this.

So, no cleanup.

@blowdart blowdart closed this as completed Jun 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants