Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

BCL API review: Rename GetCofigurationSection() and GetConfigurationSections() methods on IConfiguration #231

Closed
divega opened this issue Jun 29, 2015 · 2 comments

Comments

@divega
Copy link

divega commented Jun 29, 2015

The current names contains redundancy and aren't very clear. Here are some suggested changes we believe help improve on that:

  • GetConfigurationSection() changes to GetSection()
  • GetConfigurationSections() changes to GetChildren()
    • argument of GetChildren() overload should be parentKey
@divega divega changed the title BCL API review feedback: Rename GetCofigurationSection() and GetConfigurationSections() methods BCL API review feedback: Rename GetCofigurationSection() and GetConfigurationSections() methods on IConfiguration Jun 29, 2015
@divega divega changed the title BCL API review feedback: Rename GetCofigurationSection() and GetConfigurationSections() methods on IConfiguration BCL API review: Rename GetCofigurationSection() and GetConfigurationSections() methods on IConfiguration Jun 30, 2015
@tlc-sundown
Copy link

Sometimes we talk about sections, sometimes about children. Can we not define once and for all what we're talking about ?

  • GetConfigurationSection() changes to GetChild()
  • GetConfigurationSections() changes to GetChildren()

or

  • GetConfigurationSection() changes to GetSection()
  • GetConfigurationSections() changes to GetSections()

@divega
Copy link
Author

divega commented Aug 26, 2015

This was done in beta7 in ddd7c42. It is now superseded by #269 which talks about further changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants