This repository has been archived by the owner on Feb 25, 2021. It is now read-only.
Fix diffing when "bind" is combined with conditional attribute. Fixes #624 #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| oldStartIndex = NextSiblingIndex(oldTree[oldStartIndex], oldStartIndex); | ||
| newStartIndex = NextSiblingIndex(newTree[newStartIndex], newStartIndex); | ||
| oldStartIndex++; | ||
| newStartIndex++; |
There was a problem hiding this comment.
Should always have just been "++" here, since attribute frames are always a continuous flat list. Attributes don't have descendants to skip over.
rynowak
approved these changes
Apr 20, 2018
|
Still Not Working. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that we were using incorrect logic to update the indices during the attribute diffing. The problem only manifests given a very specific diffing scenario because of a fluke in how the memory for a
RenderTreeFrameis laid out.Fortunately the fixed code is much simpler. And we get a minor perf boost for free.