Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency from Blazor.Build -> Razor.Design #16227

Closed
rynowak opened this issue Apr 11, 2018 · 7 comments
Closed

Add dependency from Blazor.Build -> Razor.Design #16227

rynowak opened this issue Apr 11, 2018 · 7 comments
Assignees
Labels
area-blazor Includes: Blazor, Razor Components

Comments

@rynowak
Copy link
Member

rynowak commented Apr 11, 2018

Discussed this in gitter, it's not clear from looking at our templates which version of Razor.Design is supposed to match a given build of the Blazor packages, because we use PrivateAssets=All.

I think instead we should use PrivateAssets=None and bake a package reference in Blazor.Build, then we can remove Razor.Design from the template and rely on transitivity.

@SteveSandersonMS any reason why we shouldn't do this in dev?

@SteveSandersonMS
Copy link
Member

Sounds good to me!

@rynowak
Copy link
Member Author

rynowak commented Apr 12, 2018

Great, I'll take this one then.

@rynowak rynowak self-assigned this Apr 12, 2018
@rynowak
Copy link
Member Author

rynowak commented Apr 25, 2018

79a620a

@rynowak rynowak closed this as completed Apr 25, 2018
@rynowak
Copy link
Member Author

rynowak commented Apr 25, 2018

Tagging this an an enhancements. We will need to add to the release notes that users can remove the package reference to Razor.Design.

@SteveSandersonMS
Copy link
Member

@rynowak Will you be rolling this back following the email discussion?

@rynowak
Copy link
Member Author

rynowak commented Apr 26, 2018

No. The email discussion is related to issue #16143 and whether we depend on 2.1.0-RC.

We currently depend on 2.1.0-preview2-final

@rynowak
Copy link
Member Author

rynowak commented Apr 26, 2018

I've deleted my comment on #16143 about us using the RC in 0.3.0 because apparently that's not possible.

@mkArtakMSFT mkArtakMSFT transferred this issue from dotnet/blazor Oct 27, 2019
@mkArtakMSFT mkArtakMSFT added the area-blazor Includes: Blazor, Razor Components label Oct 27, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

No branches or pull requests

3 participants