Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for _Imports.razor #6374

Closed
6 tasks done
rynowak opened this issue Jan 4, 2019 · 1 comment
Closed
6 tasks done

Add support for _Imports.razor #6374

rynowak opened this issue Jan 4, 2019 · 1 comment
Assignees
@ajaybhargavb
Labels
area-blazor Includes: Blazor, Razor Components Components Big Rock This issue tracks a big effort which can span multiple issues Done This issue has been fixed
Milestone
3.0.0-preview4

Comments

@rynowak
Copy link
Member

rynowak commented Jan 4, 2019 •
edited by ajaybhargavb
Loading

Design Notes: https://github.com/aspnet/specs/blob/master/notes/ViewImports_in_the_components_world.md

Partially blocked by: #4057

  • Add support _Imports.razor and tests
  • Make _ViewImports.cshtml apply to views and _Imports.razor apply to components
  • Treat _Imports.razor as a distinct FileKind in SDK/Tooling
  • Limit _ViewImports.cshtml to directives that apply to views, Limit _Imports.razor to directives that apply to components
  • Make it an error to include code, markup, and block directives in _Imports.razor
  • Make sure generated class from _Imports.razor doesn't show up in compiled code
@rynowak rynowak added Needs: Design This issue requires design work before implementating. area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jan 4, 2019
@rynowak rynowak changed the title Design Review: What's the interaction between _ViewImports and .razor files? Add support for _Imports.razor Jan 16, 2019
@rynowak
Copy link
Member Author

rynowak commented Jan 16, 2019

I've broken down the feature with a rough breakdown that makes sense to me. Who implements this feature can divide it however they want, this is just a suggestion 😆

@rynowak rynowak added 1 - Ready and removed Needs: Design This issue requires design work before implementating. labels Jan 16, 2019
@rynowak rynowak added this to the 3.0.0-preview3 milestone Jan 16, 2019
@SteveSandersonMS SteveSandersonMS added the area-blazor Includes: Blazor, Razor Components label Feb 6, 2019
@rynowak rynowak added the Components Big Rock This issue tracks a big effort which can span multiple issues label Mar 4, 2019
@rynowak rynowak mentioned this issue Mar 4, 2019
Closed
56 tasks
@danroth27 danroth27 mentioned this issue Mar 11, 2019
Closed
@mkArtakMSFT mkArtakMSFT mentioned this issue Mar 14, 2019
Closed
@ajaybhargavb ajaybhargavb mentioned this issue Mar 21, 2019
Merged
@ajaybhargavb ajaybhargavb mentioned this issue Mar 22, 2019
Merged
@ajaybhargavb ajaybhargavb added Done This issue has been fixed and removed 2 - Working labels Mar 27, 2019
@mkArtakMSFT mkArtakMSFT removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels May 9, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
area-blazor Includes: Blazor, Razor Components Components Big Rock This issue tracks a big effort which can span multiple issues Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview4
Development

No branches or pull requests
5 participants
@SteveSandersonMS @rynowak @ajaybhargavb @danroth27 @mkArtakMSFT