Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceManagerWithCultureStringLocalizer class and WithCulture interface member to be removed #407

Open
ryanbrandenburg opened this issue Mar 3, 2020 · 1 comment
Labels
5.0.0 Announcements related to ASP.NET Core 5.0 Announcement Breaking change Documented The breaking change has been published to the .NET Core docs

Comments

@ryanbrandenburg
Copy link

Following up on #346.

The ResourceManagerWithCultureStringLocalizer class and WithCulture interface member were often sources of confusion for users of Localization, especially if they wanted to create their own IStringLocalizer implementation. These items give the user the impression that we expect an IStringLocalizer instance to be "per-language, per-resource", when actually they should only be "per-resource", with the language searched for determined by the CultureInfo.CurrentUICulture at execution time. To remove this source of confusion and to avoid APIs which we don't want users to use these were obsoleted in 3.0.0-preview3, and they are removed in 5.0.0.

For context, see #346 and dotnet/aspnetcore#3324.

See dotnet/aspnetcore#7756 for discussion.

@ryanbrandenburg ryanbrandenburg added Announcement Breaking change 5.0.0 Announcements related to ASP.NET Core 5.0 Documented The breaking change has been published to the .NET Core docs labels Mar 3, 2020
@PriyaPurkayastha
Copy link

@scottaddie for awareness since this will need to be documented for .NET 5
@ryanbrandenburg can you please remove the "Documented" label - I don't have access to remove it? Scott adds that label after he publishes this to .NET Core docs.

@aspnet aspnet locked as resolved and limited conversation to collaborators Mar 3, 2020
@scottaddie scottaddie removed the Documented The breaking change has been published to the .NET Core docs label Mar 3, 2020
@scottaddie scottaddie added the Documented The breaking change has been published to the .NET Core docs label Apr 29, 2020
@ryanbrandenburg ryanbrandenburg added Documented The breaking change has been published to the .NET Core docs and removed Documented The breaking change has been published to the .NET Core docs labels May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
5.0.0 Announcements related to ASP.NET Core 5.0 Announcement Breaking change Documented The breaking change has been published to the .NET Core docs
Projects
None yet
Development

No branches or pull requests

3 participants