Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed extensibility for DefaultHttpContext #338

Open
davidfowl opened this issue Jan 9, 2019 · 0 comments
Open

Removed extensibility for DefaultHttpContext #338

davidfowl opened this issue Jan 9, 2019 · 0 comments
Labels
3.0.0 Announcements related to ASP.NET Core 3.0 Announcement Breaking change Documented The breaking change has been published to the .NET Core docs Migrated
Milestone
3.0.0

Comments

@davidfowl
Copy link
Member

davidfowl commented Jan 9, 2019 •
edited by JamesNK
Loading

As part of performance improvements made to ASP.NET Core 3.0 (dotnet/aspnetcore#6504), we've removed the extensibility of DefaultHttpContext (it is now sealed). This extensibility was provided initially to allow pooling of the HttpContext but it introduced more complexity than necessary and precluded other optimizations. As a result, we decided to remove this extensibility.

If you're using Mock<DefaultHttpContext> in your unit tests, we recommend using Mock<HttpContext> instead.

Please discuss this on dotnet/aspnetcore#6534

[This announcement has been migrated to: dotnet/docs#14771]
@davidfowl davidfowl added Announcement Breaking change 3.0.0 Announcements related to ASP.NET Core 3.0 labels Jan 9, 2019
@davidfowl davidfowl added this to the 3.0.0 milestone Jan 9, 2019
This was referenced Jan 9, 2019
Merged
Closed
@aspnet aspnet locked and limited conversation to collaborators Jan 9, 2019
@JamesNK JamesNK removed their assignment Sep 28, 2019
@scottaddie scottaddie added the Documented The breaking change has been published to the .NET Core docs label Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3.0.0 Announcements related to ASP.NET Core 3.0 Announcement Breaking change Documented The breaking change has been published to the .NET Core docs Migrated
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@davidfowl @JamesNK @scottaddie