Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack.config.js.tmpl assumes commonjs #141

Open
Aghassi opened this issue Feb 6, 2024 · 2 comments
Open

webpack.config.js.tmpl assumes commonjs #141

Aghassi opened this issue Feb 6, 2024 · 2 comments
Labels
untriaged Requires traige

Comments

@Aghassi
Copy link
Contributor

Aghassi commented Feb 6, 2024

module.exports = function () {

This line doesn't consider that the user may provide an ESM based config, which means this will error when running webpack from a project with type: "module" in package.json.

I've patched around this internally, but I'm still trying to think of how best to have the rules determine this without the user specifying.

@github-actions github-actions bot added the untriaged Requires traige label Feb 6, 2024
@stoiky
Copy link
Contributor

stoiky commented Feb 27, 2024

Same for us, we had to patch webpack.config.js.tmpl

@jbruce1-ocrolus
Copy link

same we similarly we had to patch the config.js.tmpl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
untriaged Requires traige
Projects
Status: No status
Development

No branches or pull requests

3 participants