From 2a0d08e04ac93924fed814d8f12d30148804251f Mon Sep 17 00:00:00 2001 From: Greg Magolan Date: Sat, 6 Apr 2024 09:51:30 -0700 Subject: [PATCH] chore: drop TODOs earmarked for 2.0 that won't be done yet (#1607) --- js/private/bash.bzl | 6 +++--- js/private/js_binary.sh.tpl | 1 - js/private/test/snapshots/bzlmod/launcher.sh | 1 - js/private/test/snapshots/wksp/launcher.sh | 1 - 4 files changed, 3 insertions(+), 6 deletions(-) diff --git a/js/private/bash.bzl b/js/private/bash.bzl index 6095ec0ed..ac005db9c 100644 --- a/js/private/bash.bzl +++ b/js/private/bash.bzl @@ -1,8 +1,8 @@ "Bash snippets for js rules" -# TODO(2.0): Instead of setting a new RUNFILES env; just set RUNFILES_DIR if it is not set; -# needs testing to know if RUNFILES_DIR is set always set to the same value as RUNFILES -# when it is set. +# TODO: Instead of setting a new RUNFILES env; just set RUNFILES_DIR if it is not set; +# needs testing to know if RUNFILES_DIR is set always set to the same value as RUNFILES +# when it is set. # Bash snipped to initialize the RUNFILES environment variable. # Depends on there being a logf_fatal function defined. # NB: If this can be generalized fully in the future and not depend on logf_fatal diff --git a/js/private/js_binary.sh.tpl b/js/private/js_binary.sh.tpl index d98583787..484e9ec20 100644 --- a/js/private/js_binary.sh.tpl +++ b/js/private/js_binary.sh.tpl @@ -147,7 +147,6 @@ trap _exit EXIT # Initialize RUNFILES environment variable # ============================================================================== {{initialize_runfiles}} -# TODO(2.0): export only JS_BINARY__RUNFILES export RUNFILES JS_BINARY__RUNFILES="$RUNFILES" export JS_BINARY__RUNFILES diff --git a/js/private/test/snapshots/bzlmod/launcher.sh b/js/private/test/snapshots/bzlmod/launcher.sh index 4c83b07f6..9a7a887cf 100644 --- a/js/private/test/snapshots/bzlmod/launcher.sh +++ b/js/private/test/snapshots/bzlmod/launcher.sh @@ -264,7 +264,6 @@ if [ "${RUNFILES:0:1}" != "/" ]; then RUNFILES="$PWD/$RUNFILES" fi -# TODO(2.0): export only JS_BINARY__RUNFILES export RUNFILES JS_BINARY__RUNFILES="$RUNFILES" export JS_BINARY__RUNFILES diff --git a/js/private/test/snapshots/wksp/launcher.sh b/js/private/test/snapshots/wksp/launcher.sh index 8f768846f..cde9404ba 100644 --- a/js/private/test/snapshots/wksp/launcher.sh +++ b/js/private/test/snapshots/wksp/launcher.sh @@ -264,7 +264,6 @@ if [ "${RUNFILES:0:1}" != "/" ]; then RUNFILES="$PWD/$RUNFILES" fi -# TODO(2.0): export only JS_BINARY__RUNFILES export RUNFILES JS_BINARY__RUNFILES="$RUNFILES" export JS_BINARY__RUNFILES