From 37b3a1416d1716be4b2068966486af1455be775a Mon Sep 17 00:00:00 2001 From: Nate Wright Date: Tue, 11 Apr 2023 09:47:20 +0100 Subject: [PATCH] pkp/pkp-lib#8346 Fix race conditions in submission wizard tests --- cypress/tests/integration/SubmissionWizard.cy.js | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/cypress/tests/integration/SubmissionWizard.cy.js b/cypress/tests/integration/SubmissionWizard.cy.js index 478f6210798..a9b7c6b6021 100644 --- a/cypress/tests/integration/SubmissionWizard.cy.js +++ b/cypress/tests/integration/SubmissionWizard.cy.js @@ -224,10 +224,10 @@ describe('Submission Wizard', function() { }); cy.changeLanguage('fr_CA'); - cy.get('button:contains("Continue")').click(); - cy.get('button:contains("Continue")').click(); - cy.get('button:contains("Continue")').click(); - cy.get('button:contains("Continue")').click(); + cy.get('button:contains("Continuer")').click(); + cy.get('button:contains("Continuer")').click(); + cy.get('button:contains("Continuer")').click(); + cy.get('button:contains("Continuer")').click(); cy.get('button:contains("Soumettre")').should('be.disabled'); cy.get('legend:contains("Droit d\'auteur")') .parent() @@ -408,6 +408,8 @@ describe('Submission Wizard', function() { // All errors should be gone and submit should be allowed. cy.get('.pkpSteps button:contains("Review")').click(); + cy.get('.submissionWizard__loadingReview').contains('Checking your submission'); + cy.get('.submissionWizard__loadingReview').contains('Checking your submission').should('not.exist'); cy.get('*:contains("There are one or more problems")').should('not.exist'); cy.get('button:contains("Submit")').should('be.enabled'); cy.get('*:contains("You must upload at least one Article Text file.")').should('not.exist'); @@ -596,9 +598,11 @@ describe('Submission Wizard', function() { cy.get('#forTheEditors-subjects-control-fr_CA').type('Sociologie française', {delay: 0}); cy.get('li:contains("Sociologie française")'); cy.get('#forTheEditors-subjects-control-fr_CA').type('{downarrow}{enter}', {delay: 0}); - cy.get('.pkpSteps button:contains("Review")').click(); // Should be able to submit! + cy.get('.pkpSteps button:contains("Review")').click(); + cy.get('.submissionWizard__loadingReview').contains('Checking your submission'); + cy.get('.submissionWizard__loadingReview').contains('Checking your submission').should('not.exist'); cy.get('button:contains("Submit")').click(); cy.contains('The submission, ' + submission.title.en + ', will be submitted to Journal of Public Knowledge for editorial review.'); cy.get('.modal__footer button:contains("Submit")').click();