Fix noise image statistics #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: I'm not using f-strings for log messages because this is considered bad practice in logging. f-strings are greedy and will be computed even if the log isn't printed to the screen. While this isn't an issue here since the log message is quick to render, it's good practice to always print log messages in this way in case the message requires an expensive calculation. See: https://bugs.python.org/issue46200 for some discussion of this.
ddobie
requested changes
Sep 25, 2024
Co-authored-by: Dougal Dobie <[email protected]>
Co-authored-by: Dougal Dobie <[email protected]>
ddobie
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for negative pixes as well as 0 or NaN ones in the noise images when calculating statistics.
This fixes #753