Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support defer loading of dataTables data #638

Merged
merged 3 commits into from
Mar 3, 2022

Conversation

marxide
Copy link
Contributor

@marxide marxide commented Mar 2, 2022

Adds support to defer the loading of dataTables data with AJAX. Applied to the sources table on the source query page, this stops the results table from being populated with all sources. The results table is only populated when the user submits a query using the form. If the user wants to view all sources, they can still do this by submitting an empty query.

Closes #629

@marxide marxide added enhancement New feature or request UI User Interface labels Mar 2, 2022
@marxide marxide marked this pull request as ready for review March 2, 2022 19:21
@marxide marxide requested a review from ajstewart March 2, 2022 19:21
@ajstewart
Copy link
Contributor

Just thought, not sure if there is any wording in the docs that needs updating. I.e. it implies the results are already there.

@marxide marxide merged commit 85aa053 into dev Mar 3, 2022
@marxide marxide deleted the iss-629-defer-datatables-loading branch March 3, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid API call on initial source query page load
2 participants