Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added error handling to external queries #616

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Conversation

marxide
Copy link
Contributor

@marxide marxide commented Feb 9, 2022

Failure to connect to an external query source is now handled. In the SIMBAD case, it will try the Harvard mirror if the CDS endpoint fails.
Fixes #615
[skip ci]

@marxide marxide requested a review from ajstewart February 9, 2022 21:34
Copy link
Contributor

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me!

@marxide marxide force-pushed the iss-615-external-queries branch from e87561b to 074995a Compare February 10, 2022 00:29
@marxide marxide merged commit 1f57760 into dev Feb 10, 2022
@marxide marxide deleted the iss-615-external-queries branch February 10, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External query failure blocks all external queries
2 participants